chore: Updating changelog and minor improvement in the icon button lo…

…gic + tests (#106)
erickzanardo · Dec 19, 2023 · 7d7a9bd · 7d7a9bd
1 parent 58a2a56
commit 7d7a9bd
Show file tree

Hide file tree

Showing 4 changed files with 110 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,8 @@
  - feat: add `NesIcons.owl`
  - feat: add `NesIconBadge`
  - feat: add `NesIcons.letter`
+ - feat: adding arrow direction to `NesTooltip`
+ - fix: Icon button disabled property
 
 # 0.10.0
  - feat: add `NesIcons.user`

diff --git a/example/lib/gallery/sections/icon_buttons.dart b/example/lib/gallery/sections/icon_buttons.dart
@@ -65,7 +65,11 @@ class _IconEntry extends StatelessWidget {
   Widget build(BuildContext context) {
     return Padding(
       padding: const EdgeInsets.all(8),
-      child: NesIconButton(icon: data, onPress: () {}, disabled: disabled, ),
+      child: NesIconButton(
+        icon: data,
+        onPress: () {},
+        disabled: disabled,
+      ),
     );
   }
 }
diff --git a/lib/src/widgets/nes_icon_button.dart b/lib/src/widgets/nes_icon_button.dart
@@ -45,6 +45,7 @@ class NesIconButton extends StatelessWidget {
   final bool? disabled;
 
   bool _isDisabled() =>
+      (disabled ?? false) ||
       onPress == null && onPressStart == null && onPressEnd == null;
 
   @override
@@ -53,9 +54,9 @@ class NesIconButton extends StatelessWidget {
       onPress: onPress,
       onPressStart: onPressStart,
       onPressEnd: onPressEnd,
-      disabled: disabled ?? false || _isDisabled(),
+      disabled: _isDisabled(),
       child: Opacity(
-        opacity: (disabled ?? false || _isDisabled()) ? .2 : 1.0,
+        opacity: _isDisabled() ? .2 : 1.0,
         child: NesIcon(
           iconData: icon,
           size: size,

diff --git a/test/src/widgets/nes_icon_button_test.dart b/test/src/widgets/nes_icon_button_test.dart
@@ -40,5 +40,105 @@ void main() {
 
       expect(calls, equals(1));
     });
+
+    testWidgets('is disabled when there is no listener', (tester) async {
+      await tester.pumpWidget(
+        MaterialApp(
+          theme: flutterNesTheme(),
+          home: Scaffold(
+            body: NesIconButton(
+              icon: NesIcons.add,
+            ),
+          ),
+        ),
+      );
+
+      final nesPressable = tester.widget<NesPressable>(
+        find.byType(NesPressable),
+      );
+      expect(nesPressable.disabled, isTrue);
+    });
+
+    testWidgets('is not disabled when there is is a onPress', (tester) async {
+      await tester.pumpWidget(
+        MaterialApp(
+          theme: flutterNesTheme(),
+          home: Scaffold(
+            body: NesIconButton(
+              onPress: () {},
+              icon: NesIcons.add,
+            ),
+          ),
+        ),
+      );
+
+      final nesPressable = tester.widget<NesPressable>(
+        find.byType(NesPressable),
+      );
+      expect(nesPressable.disabled, isFalse);
+    });
+
+    testWidgets(
+      'is not disabled when there is is a onPressStart',
+      (tester) async {
+        await tester.pumpWidget(
+          MaterialApp(
+            theme: flutterNesTheme(),
+            home: Scaffold(
+              body: NesIconButton(
+                onPressStart: () {},
+                icon: NesIcons.add,
+              ),
+            ),
+          ),
+        );
+
+        final nesPressable = tester.widget<NesPressable>(
+          find.byType(NesPressable),
+        );
+        expect(nesPressable.disabled, isFalse);
+      },
+    );
+
+    testWidgets('is not disabled when there is is a onPressEnd',
+        (tester) async {
+      await tester.pumpWidget(
+        MaterialApp(
+          theme: flutterNesTheme(),
+          home: Scaffold(
+            body: NesIconButton(
+              onPressEnd: () {},
+              icon: NesIcons.add,
+            ),
+          ),
+        ),
+      );
+
+      final nesPressable = tester.widget<NesPressable>(
+        find.byType(NesPressable),
+      );
+      expect(nesPressable.disabled, isFalse);
+    });
+
+    testWidgets('is disabled when there is is a listener but disabled = true',
+        (tester) async {
+      await tester.pumpWidget(
+        MaterialApp(
+          theme: flutterNesTheme(),
+          home: Scaffold(
+            body: NesIconButton(
+              onPressEnd: () {},
+              disabled: true,
+              icon: NesIcons.add,
+            ),
+          ),
+        ),
+      );
+
+      final nesPressable = tester.widget<NesPressable>(
+        find.byType(NesPressable),
+      );
+      expect(nesPressable.disabled, isTrue);
+    });
   });
 }