Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pectra-devnet-4 changes #12106

Closed
12 tasks done
yperbasis opened this issue Sep 26, 2024 · 1 comment
Closed
12 tasks done

Implement pectra-devnet-4 changes #12106

yperbasis opened this issue Sep 26, 2024 · 1 comment
Assignees
Labels
imp1 High importance pectra The Prague/Electra protocol upgrade

Comments

@yperbasis
Copy link
Member

yperbasis commented Sep 26, 2024

https://notes.ethereum.org/@ethpandaops/pectra-devnet-4

v1.0.1 release of pectra-devnet-4 tests release at https://github.com/ethereum/execution-spec-tests already merged.

@yperbasis yperbasis added pectra The Prague/Electra protocol upgrade imp1 High importance labels Sep 26, 2024
@somnathb1
Copy link
Contributor

Priority high here means importance, not all EIPs in the list have been merged/finalized yet for pectra-devnet-4. The issue is expected to remain open for some time till the EIPs are finalized. The code changes will be accumulated over multiple PRs referencing this issue.

somnathb1 added a commit that referenced this issue Sep 30, 2024
yperbasis pushed a commit that referenced this issue Oct 4, 2024
somnathb1 added a commit that referenced this issue Oct 11, 2024
In summary, does away with a lot of earlier complexities related to
parsing and encoding withdrawal requests. These are now just byte
strings, essentially

Refer to the following
- ethereum/EIPs#8855 (flat requests format
update for EIP-7002)
-
https://github.com/ethereum/EIPs/pull/8934/files#diff-70472fac1debb567783ce13873323261713f3ce488a26a5c3769a9193f4a7e27R596
(Address update)

Needs interface update -
erigontech/interfaces#234

(Tasks board - #12106)
somnathb1 added a commit that referenced this issue Oct 11, 2024
In summary, does away with a lot of earlier complexities related to
parsing and encoding consolidation requests. These are now just byte
strings, essentially.

Refer to the following 
- ethereum/EIPs#8857
-
https://github.com/ethereum/EIPs/pull/8934/files#diff-01ca405a121a1fc77e03df916c4f331b030c2467a4eb66545a34e98a6e476fd6R541
(Address update)

Needs interface update -
erigontech/interfaces#237

(Tasks board - #12106)
yperbasis pushed a commit that referenced this issue Oct 22, 2024
Header data will contain this different name now

Ref: ethereum/EIPs#8924
Issue board: #12106
yperbasis pushed a commit that referenced this issue Oct 23, 2024
Requests to be removed from body and put into Engine-API sidecar
Ref: ethereum/execution-apis#591
Issue board: #12106
somnathb1 added a commit that referenced this issue Oct 23, 2024
Summary of changes
- Remove `Requests` interface in favour of new `FlatRequest` struct
- Add changes for new `RequestHash` calculation that `sha256` digests
the set of flat requests
- Remove `Requests` from block and body related structs and methods
- Set of requests that gets pulled at the `Finalize` stage is now
returned from there, both for execution and block-building

Ref1: ethereum/execution-apis#591
Ref2: ethereum/EIPs#8854
Ref3: ethereum/EIPs#8924


Needs interface change -
erigontech/interfaces#239

(Tasks board - #12106)
somnathb1 added a commit that referenced this issue Oct 24, 2024
Use FlatRequest instead of a different type - DepositRequest defined
earlier. This allows all request to align, with the differences in
Deposit Requests separated out into functions rather than receiver
methods.

Tasks board: #12106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imp1 High importance pectra The Prague/Electra protocol upgrade
Projects
None yet
Development

No branches or pull requests

2 participants