Flatten EIP-7251 Consolidation Requests encoding #12167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somnathb1
added
the
do-not-merge
somnathb1
removed
the
do-not-merge
|
Even further simplifications can be done, will do in later PRs |
racytech
approved these changes
Oct 11, 2024
yperbasis
reviewed
Oct 11, 2024
| @@ -31,7 +31,8 @@ import ( | |||
| const WithdrawalRequestType byte = 0x01 | |||
| const DepositRequestType byte = 0x00 | |||
| const ConsolidationRequestType byte = 0x02 | |||
| const WithdrawalRequestDataLen = 76 // addr + pubkey + amt | |||
| const ConsolidationRequestDataLen = 116 // addr + sourcePubkey + targetPubkey | |||
There was a problem hiding this comment.
Duplicated in consensus/misc/eip7251.go
There was a problem hiding this comment.
Will remove either/both, going forward. Should do the cleanup after further simplification in next PRs
yperbasis
added a commit
that referenced
this pull request
Oct 24, 2024
Cherry pick #12167 into `release/2.61` Co-authored-by: Somnath <snb895@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In summary, does away with a lot of earlier complexities related to parsing and encoding consolidation requests. These are now just byte strings, essentially.
Refer to the following
Needs interface update - erigontech/interfaces#237
(Tasks board - #12106)