Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strongerrunner #12602

Merged
merged 7 commits into from
Nov 6, 2024
Merged

Strongerrunner #12602

merged 7 commits into from
Nov 6, 2024

Conversation

dvovk
Copy link
Member

@dvovk dvovk commented Nov 4, 2024

@AskAlexSharov No I haven't known it, thanks.

@dvovk dvovk added the do-not-merge PR that is in a merge-able state but is waiting for something else to take place before merging label Nov 4, 2024
@AskAlexSharov
Copy link
Collaborator

@dvovk do you know about -p 2 in https://github.com/erigontech/erigon/blob/main/Makefile#L68 ?

@dvovk dvovk mentioned this pull request Nov 5, 2024
@dvovk dvovk removed the do-not-merge PR that is in a merge-able state but is waiting for something else to take place before merging label Nov 5, 2024
@dvovk
Copy link
Member Author

dvovk commented Nov 5, 2024

For some reasons new runner doesn't work at this branch so the last place to check is the main branch. After runners speed comparison I am going to remove slowest one.

Copy link
Member

@lystopad lystopad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From devops perspective workflow configuration looks ok.

@AskAlexSharov
Copy link
Collaborator

Integration tests / tests (ubuntu-22.04) (pull_request) Successful in 34m - in main i saw 29m

@dvovk dvovk merged commit 5f65bb8 into main Nov 6, 2024
15 of 16 checks passed
@dvovk dvovk deleted the strongerrunner branch November 6, 2024 07:03
dvovk added a commit that referenced this pull request Nov 6, 2024
@dvovk dvovk mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants