Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kgn algorithm #506

Merged
merged 3 commits into from
Jun 17, 2024
Merged

add kgn algorithm #506

merged 3 commits into from
Jun 17, 2024

Conversation

Henry-yan
Copy link
Contributor

add kgn algorithm

@maumueller
Copy link
Collaborator

Hi @Henry-yan! Thanks for your contribution: Could you link to your repo in the README.md and maybe add a bit information (is there a paper?) Are you planning to open-source your contribution?

@Henry-yan
Copy link
Contributor Author

Hi @Henry-yan! Thanks for your contribution: Could you link to your repo in the README.md and maybe add a bit information (is there a paper?) Are you planning to open-source your contribution?↳

Thank you for your suggestion, we have updated the README.md with the repository link. We currently do not have plans to open source.

@Henry-yan
Copy link
Contributor Author

Hello @maumueller, would you please consider merge this PR? Since there are already a lot of close-source algorithm in this repo, they should be fairly treated.

@Henry-yan
Copy link
Contributor Author

Hello @maumueller @erikbern , we plan to submit a paper, and upon its acceptance, we intend to open-source our algorithm. Could you please consider merging our pull request first? It would be greatly appreciated.

@maumueller
Copy link
Collaborator

Alright, I'm merging this for now.

@maumueller maumueller merged commit da31331 into erikbern:main Jun 17, 2024
35 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants