sp_QuickieStore: Made last_ columns report the actual lasts, rather than the maximum of them #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdarlingdata
added
bug
erikdarlingdata
added a commit
that referenced
this pull request
Oct 29, 2024
Fixes a big introduced in #492 where a column in the qsrs_with_lasts derived table was missing a column alias ( = NULL) on older versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #474 . There wasn't really much to this. I just had to add in some calls to
LAST_VALUE.This was surprisingly hard to test. I'm fully confident in the
runtime_statstable, but the table that pulls from the plan cache is inherently noisy and testing the tables showing the wait stats was so difficult that I started to question the other columns in them. Shockingly often, the wait stats tables would give identical outputs both for this version ofsp_QuickieStoreand for an older version.