-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssl: Remove compression handling #7447
ssl: Remove compression handling #7447
Conversation
CT Test Results 2 files 66 suites 48m 58s ⏱️ For more details on these failures, see this check. Results for commit 86bab0f. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ssl.xml - remove Compression argument from server_reuse_session option?
- ssl_cipher.erl - rename variables so they don't include "Compressed" in names?
- ssl_alert.hrl - remove DECOMPRESSION_FAILURE macro? also from code comments referring to this macro?
4c9a56c
to
93ef79d
Compare
Compress is deprecated and deemed unsecure so we will never implement it, remove all handling of it to save memory and performance.
86bab0f
to
7dcca29
Compare
Compression is deprecated and deemed unsecure so we will never implement it,
remove all handling of it to save memory and performance.