Kuba/ct/ct hooks order option/otp 18682

[u3s]

No description provided.

[github-actions]

CT Test Results

    1 files    11 suites   5m 11s ⏱️
  93 tests   91 ✔️ 2 💤 0 ❌
109 runs  107 ✔️ 2 💤 0 ❌

Results for commit abde78f.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

• Complete CT logs (Download Logs)
• HTML Documentation (Download HTML Docs)
• No Windows Installer found

// Erlang/OTP Github Action Bot

[garazdawi]

The changes look good and from what I can tell they also work :)

While digging in the code I noticed that the ct_hooks option can be given to a lot of more places than we originally intended. The CTH User's Guide I wrote a long time ago restricts it to three function, but the original implementation seems to have allowed it (inadvertently) in a lot of other places which through the years have become documented, though I can't find any tests for it.

Not much we can do about that now, but I'm not sure we need to make the same mistake for ct_hook_order. IMO it should be enough to allow that option in the suite callback and in test specs/command line.

[u3s]

Not much we can do about that now, but I'm not sure we need to make the same mistake for ct_hook_order. IMO it should be enough to allow that option in the suite callback and in test specs/command line.

I will gladly reduce supported callbacks to suite. I tried to follow ct_hooks assuming it is all well thought and needed. I didn't dare to think it is all an accident ;-)

Also on 2nd thought, I think ct_hooks_order is more 'global' thing in framework than ct_hooks.