erl_lint: Warn on matching float 0.0 #7521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhogberg
added
team:VM
CT Test Results 2 files 89 suites 43m 33s ⏱️ For more details on these failures, see this check. Results for commit 5e193bd. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
bjorng
approved these changes
Aug 2, 2023
jhogberg
force-pushed
the
john/stdlib/lint-match-float-zero/OTP-18696
branch
from
260d6d1
to
5e193bd
Compare
gonzalobf
pushed a commit
to gonzalobf/recon
that referenced
this pull request
Sep 21, 2023
In OTP-27, `+0.0` and `-0.0` will no longer be the exact number so they added a compilation warning in OTP-26.1 to warn when a float 0.0 is getting match without specifying the sign: ``` rebar3 compile 0s ===> Verifying dependencies... ===> Analyzing applications... ===> Compiling recon src/recon_alloc.erl:706:7: Warning: matching on the float 0.0 will no longer also match -0.0 in OTP 27. If you specifically intend to match 0.0 alone, write +0.0 instead. src/recon_alloc.erl:706:11: Warning: matching on the float 0.0 will no longer also match -0.0 in OTP 27. If you specifically intend to match 0.0 alone, write +0.0 instead. ``` Longer explanation about why are not the same [1] Pull request adding the warning [2] [1] https://erlangforums.com/t/in-erlang-otp-27-0-0-will-no-longer-be-exactly-equal-to-0-0/2586 [2] erlang/otp#7521
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As announced on the forum,
0.0will no longer match-0.0in OTP 27 and vice versa.This PR for OTP 26.1 adds a warning in anticipation of that.