-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh: Fix windows and kernel tests for gh actions #7525
gh: Fix windows and kernel tests for gh actions #7525
Conversation
CT Test Results 3 files 143 suites 1h 36m 25s ⏱️ Results for commit 74f7ee4. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
This will hopefully get rid of error messages that the disk is full.
74f7ee4
to
7b3aa4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not merging this also to maint?
@@ -217,7 +217,7 @@ release_tests_spec: make_emakefile | |||
$(INSTALL_DATA) $(ERL_FILES) $(HRL_FILES) "$(RELSYSDIR)" | |||
$(INSTALL_DATA) $(APP_FILES) $(EXTRA_FILES) "$(RELSYSDIR)" | |||
$(INSTALL_DATA) \ | |||
kernel.spec kernel_smoke.spec kernel_bench.spec logger.spec \ | |||
kernel.spec kernel_smoke.spec kernel_bench.spec kernel_gh.spec logger.spec \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a list determining test execution scope?
is there unnecessary overlap between kernel.spec and kernel_gh.spec?
same question. for stdlib below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a list of all files to be copied when releasing tests. There is an overlap between kernel.spec
and kernel_gh.spec
because it is not possible to include specs into each other (as far as I know).
$APP.spec
is what is normally run, while in GH actions we run $APP_gh.spec
if it exists.
It is merged to maint and master, this PR is however targeted at master. |
No description provided.