Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh: Fix windows and kernel tests for gh actions #7525

Merged
merged 5 commits into from
Aug 3, 2023

Conversation

garazdawi
Copy link
Contributor

No description provided.

@garazdawi garazdawi self-assigned this Aug 2, 2023
@garazdawi garazdawi requested a review from u3s August 2, 2023 11:37
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

CT Test Results

       3 files     143 suites   1h 36m 25s ⏱️
3 255 tests 2 768 ✔️ 487 💤 0
3 763 runs  3 218 ✔️ 545 💤 0

Results for commit 74f7ee4.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

  • No CT logs found
  • No HTML docs found
  • No Windows Installer found

// Erlang/OTP Github Action Bot

@garazdawi garazdawi force-pushed the lukas/gh/fix-windows-and-kernel branch from 74f7ee4 to 7b3aa4d Compare August 3, 2023 06:05
@garazdawi garazdawi merged commit 75ae742 into erlang:master Aug 3, 2023
2 checks passed
Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not merging this also to maint?

@@ -217,7 +217,7 @@ release_tests_spec: make_emakefile
$(INSTALL_DATA) $(ERL_FILES) $(HRL_FILES) "$(RELSYSDIR)"
$(INSTALL_DATA) $(APP_FILES) $(EXTRA_FILES) "$(RELSYSDIR)"
$(INSTALL_DATA) \
kernel.spec kernel_smoke.spec kernel_bench.spec logger.spec \
kernel.spec kernel_smoke.spec kernel_bench.spec kernel_gh.spec logger.spec \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a list determining test execution scope?
is there unnecessary overlap between kernel.spec and kernel_gh.spec?
same question. for stdlib below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a list of all files to be copied when releasing tests. There is an overlap between kernel.spec and kernel_gh.spec because it is not possible to include specs into each other (as far as I know).

$APP.spec is what is normally run, while in GH actions we run $APP_gh.spec if it exists.

@garazdawi
Copy link
Contributor Author

It is merged to maint and master, this PR is however targeted at master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants