Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify gen_statem:start_link/3,4 semantics #7529

Conversation

RaimoNiskanen
Copy link
Contributor

Solves #7524

@RaimoNiskanen RaimoNiskanen added team:VM Assigned to OTP team VM team:PS Assigned to OTP team PS documentation in progress priority:medium labels Aug 2, 2023
@RaimoNiskanen RaimoNiskanen added this to the OTP-26.1 milestone Aug 2, 2023
@RaimoNiskanen RaimoNiskanen self-assigned this Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

CT Test Results

       2 files       89 suites   40m 2s ⏱️
1 916 tests 1 867 ✔️ 49 💤 0
2 210 runs  2 159 ✔️ 51 💤 0

Results for commit c1dce6f.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

Copy link
Contributor

@attah attah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definite improvement. Two minor suggestions though.

lib/stdlib/doc/src/gen_statem.xml Outdated Show resolved Hide resolved
lib/stdlib/doc/src/gen_statem.xml Show resolved Hide resolved
In OTP-26.0 `proc_lib:start*` became synchronous,
so that for all start failures the start function
does not return until the failed process has terminated.

For start link, additionally, it was changed to always
consume an `'EXIT'` messsage delivered to the calling process,
for start error returns.

See erlangGH-7524, OTP-18471, erlangGH-6339, PR-6843.
@RaimoNiskanen RaimoNiskanen force-pushed the raimo/stdlib/gen_statem-doc-start_link/GH-7524 branch from f999efb to d2c4c98 Compare August 7, 2023 09:24
@RaimoNiskanen RaimoNiskanen merged commit e102aba into erlang:maint Aug 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation in progress priority:medium team:PS Assigned to OTP team PS team:VM Assigned to OTP team VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants