Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingela/public key/policies/otp 17844 #7579

Merged
merged 2 commits into from
Nov 4, 2023
Merged

Ingela/public key/policies/otp 17844 #7579

merged 2 commits into from
Nov 4, 2023

Conversation

IngelaAndin
Copy link
Contributor

@IngelaAndin IngelaAndin commented Aug 22, 2023 •
edited
Loading

Closes #6198

@IngelaAndin IngelaAndin requested review from dgud and u3s August 22, 2023 17:47
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023 •
edited
Loading

CT Test Results

    2 files    15 suites   7m 6s ⏱️
267 tests 265 ✔️ 2 💤 0 ❌
283 runs  281 ✔️ 2 💤 0 ❌

Results for commit 9d1dda7.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin added team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI labels Aug 22, 2023
@IngelaAndin IngelaAndin force-pushed the ingela/public_key/policies/OTP-17844 branch from 00ecdca to 2d99975 Compare August 22, 2023 18:53
@IngelaAndin IngelaAndin removed the testing currently being tested, tag is used by OTP internal CI label Aug 22, 2023
@IngelaAndin IngelaAndin force-pushed the ingela/public_key/policies/OTP-17844 branch 2 times, most recently from 8caab25 to fd11be4 Compare August 23, 2023 14:01
@IngelaAndin IngelaAndin force-pushed the ingela/public_key/policies/OTP-17844 branch 2 times, most recently from 82be7d4 to 270826d Compare August 24, 2023 11:33
@IngelaAndin IngelaAndin added the testing currently being tested, tag is used by OTP internal CI label Aug 24, 2023
@IngelaAndin IngelaAndin added this to the OTP-26.1 milestone Aug 25, 2023
u3s
u3s requested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments part 1

lib/public_key/include/public_key.hrl Outdated Show resolved Hide resolved
lib/public_key/test/pkits_SUITE.erl Show resolved Hide resolved
lib/public_key/test/pkits_SUITE.erl Outdated Show resolved Hide resolved
lib/public_key/doc/src/public_key.xml Outdated Show resolved Hide resolved
lib/public_key/doc/src/public_key.xml Outdated Show resolved Hide resolved
lib/public_key/include/public_key.hrl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
u3s
u3s requested changes Aug 29, 2023
View reviewed changes
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
@IngelaAndin IngelaAndin force-pushed the ingela/public_key/policies/OTP-17844 branch 4 times, most recently from 5148860 to e678490 Compare August 29, 2023 10:41
@IngelaAndin IngelaAndin force-pushed the ingela/public_key/policies/OTP-17844 branch from ec3cc46 to 2d5acbb Compare August 31, 2023 08:37
@IngelaAndin IngelaAndin modified the milestones: OTP-26.1, OTP-26.2 Aug 31, 2023
@IngelaAndin
Copy link
Contributor Author

I changed the milestone as we like to evaluate a different tree implementation!

u3s
u3s reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more comments

lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Show resolved Hide resolved
@IngelaAndin IngelaAndin force-pushed the ingela/public_key/policies/OTP-17844 branch 3 times, most recently from 3c6a25c to 79f2a0b Compare September 22, 2023 15:18
@IngelaAndin IngelaAndin force-pushed the ingela/public_key/policies/OTP-17844 branch 3 times, most recently from 1960311 to ab4b1c9 Compare October 24, 2023 05:44
u3s
u3s reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saving comments

lib/public_key/src/pubkey_policy_tree.erl Show resolved Hide resolved
lib/public_key/src/pubkey_policy_tree.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_policy_tree.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_policy_tree.erl Outdated Show resolved Hide resolved
lib/public_key/test/pkits_SUITE.erl Outdated Show resolved Hide resolved
lib/public_key/test/pkits_SUITE.erl Outdated Show resolved Hide resolved
lib/public_key/test/pkits_SUITE.erl Outdated Show resolved Hide resolved
@u3s u3s self-requested a review October 26, 2023 16:30
u3s
u3s reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saving comments

lib/public_key/test/pkits_SUITE.erl Outdated Show resolved Hide resolved
lib/public_key/test/pkits_SUITE.erl Outdated Show resolved Hide resolved
u3s
u3s reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saving comments and replies

lib/public_key/test/pkits_SUITE.erl Show resolved Hide resolved
lib/public_key/src/pubkey_policy_tree.erl Outdated Show resolved Hide resolved
lib/public_key/test/pkits_SUITE.erl Outdated Show resolved Hide resolved
@IngelaAndin IngelaAndin force-pushed the ingela/public_key/policies/OTP-17844 branch 4 times, most recently from 485a083 to 56154d0 Compare October 27, 2023 15:33
u3s
u3s reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more comments

lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Show resolved Hide resolved
@u3s u3s self-requested a review October 27, 2023 17:41
u3s
u3s reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saving comments and replies

lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_policy_tree.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_policy_tree.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
u3s
u3s reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saving comments and replies

lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_policy_tree.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_policy_tree.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_policy_tree.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_policy_tree.erl Outdated Show resolved Hide resolved
@IngelaAndin IngelaAndin force-pushed the ingela/public_key/policies/OTP-17844 branch 2 times, most recently from eae1c0c to 00653b9 Compare October 30, 2023 20:51
u3s
u3s reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saving replies and comments.

lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
u3s
u3s reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saving notes from discussion

lib/public_key/src/pubkey_cert.erl Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
lib/public_key/src/pubkey_cert.erl Outdated Show resolved Hide resolved
@IngelaAndin IngelaAndin force-pushed the ingela/public_key/policies/OTP-17844 branch 4 times, most recently from 5ee3e86 to f8d06b2 Compare November 1, 2023 16:22
@IngelaAndin IngelaAndin force-pushed the ingela/public_key/policies/OTP-17844 branch from f8d06b2 to 0b74f6f Compare November 2, 2023 08:45
@IngelaAndin IngelaAndin force-pushed the ingela/public_key/policies/OTP-17844 branch from 0b74f6f to 9d1dda7 Compare November 3, 2023 07:29
@IngelaAndin IngelaAndin merged commit 7891cd1 into erlang:maint Nov 4, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgud dgud dgud left review comments

@u3s u3s u3s approved these changes

Assignees

@IngelaAndin IngelaAndin

Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
OTP-26.2
Development

Successfully merging this pull request may close these issues.
4 participants
@IngelaAndin @dgud @u3s @garazdawi