inets: start ssl and dependencies by default #7588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 21 suites 13m 1s ⏱️ For more details on these failures, see this check. Results for commit 9ad7184. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
kikofernandez
force-pushed
the
kiko/inets/update-httpc-documentation/GH-7580
branch
from
cb617dc
to
9626b97
Compare
kikofernandez
force-pushed
the
kiko/inets/update-httpc-documentation/GH-7580
branch
from
9626b97
to
692532b
Compare
IngelaAndin
reviewed
Aug 25, 2023
IngelaAndin
reviewed
Aug 25, 2023
kikofernandez
force-pushed
the
kiko/inets/update-httpc-documentation/GH-7580
branch
2 times, most recently
from
2f2a80a
to
35dfe32
Compare
IngelaAndin
reviewed
Aug 25, 2023
kikofernandez
force-pushed
the
kiko/inets/update-httpc-documentation/GH-7580
branch
from
35dfe32
to
aaad5aa
Compare
inets will start ssl by default together with its dependencies. the main reason for this change is that https is almost standard nowadays and inets:start/0/1/2/3 is a utility function that can benefit from not having to manually pass new options to allow redirects from http to https
kikofernandez
force-pushed
the
kiko/inets/update-httpc-documentation/GH-7580
branch
from
aaad5aa
to
bc97027
Compare
|
Closing PR and re-opening due to internal branch naming scheme |
kikofernandez
deleted the
kiko/inets/update-httpc-documentation/GH-7580
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the
inetsapp starts thessland its dependencies by default.This is a good standard nowadays, preventing redirects from
httptohttpsto break, so that it is easier to start and one does not need to startsslandcryptomanually.Closes #7580