Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Work-in-Progress is to add SIG(0) support to OTP; similarly to the support for TSIG in #6985.
This work is necessary so that user code may implement the signing required by SRP; I have created a reference client implementation.
Outstanding tasks:
decoderencoderOutstanding Questions:
#dns_rr_sig{}
part so the rest could be handled in user land; similarly to TSIG we need to know the byte offset of the SIG(0) record and this is best worked out ininet_dns.erl
(which also includesFORMERR
handling) to avoid having a second DNS decoder to figure that outpublic_key.hrl
is included ininet_dns.erl
{encode,decode}_key_publickey/2
which maybe should be moved intoinet_dns_sig0.erl
{encode,decode}_algname/1
remained ininet_dns.erl
public_key
types in the KEY RR as the binary would not be usable unable to do this anyway (avoiding needless duplication in user code)Things that make this fun, I am unable to see how end-to-end testing will work as:
dnspython
does not support SIG(0)Maybe a rework of the reference Python implementation would suffice as a sort of DNS bitbanger?