kernel: Don't load group history when in noshell mode #8746
+24
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading of group_history synchornizes with kernel_sup in order to use disk_log. Doing that when in the user process can lead to a deadlock if logger (or anything really) tries to write to standard out at the same time. Normally the deadlock will solve itself when the kernel application is started, but if it should fail to start for some reason user is terminated before it can print anything and logger will print the log messages to standard error instead.
CT Test Results 2 files 65 suites 1h 1m 19s ⏱️ Results for commit ec91a1f. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading of group_history synchornizes with kernel_sup in order to use disk_log. Doing that when in the user process can lead to a deadlock if logger (or anything really) tries to write to standard out at the same time. Normally the deadlock will solve itself when the kernel application is started, but if it should fail to start for some reason user is terminated before it can print anything and logger will print the log messages to standard error instead.