Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common_test] Fix total execution time in case of timetrap_timeout #8761

Closed
wants to merge 2 commits into from

Conversation

saydome
Copy link

@saydome saydome commented Aug 29, 2024

Hi!

We noticed that when a test case fails with timetrap_timeout, the generated html log the time correctly shows the time in seconds but then the time itself is incorrectly added to the total execution time in milliseconds.
image

Divided the 'DiedTime' by 1000 when the cause is timetrap_timeout

If it is possible we would like to have this change released on 26.2.5.2 as 26.2.5.3.

Best Regards,
Domonkos Say

In case of timetrap_timeout the test_server_total_time is incorrectly incremented with the timeout value in milliseconds instead of seconds.
@CLAassistant
Copy link

CLAassistant commented Aug 29, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

CT Test Results

Tests are running... https://github.com/erlang/otp/actions/runs/10616426469

Results for commit 7309d01

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

  • No CT logs found
  • No HTML docs found
  • No Windows Installer found

// Erlang/OTP Github Action Bot

@u3s u3s added the team:PS Assigned to OTP team PS label Aug 30, 2024
@Whaileee
Copy link
Contributor

Whaileee commented Sep 4, 2024

Hello.
Thank you for your contribution. This issue is already known, and the solution for this case and others is currently being tested.

Best regards.
Konrad

@Whaileee Whaileee closed this Sep 4, 2024
@saydome
Copy link
Author

saydome commented Sep 4, 2024

Hi Konrad (@Whaileee)!

Can you please share the commit or reference the pull request where the mentioned issue is resolved? Also will that solution be released in OTP 26.2.5.3 or should we request the release of the fix in a Github issue?

Br,
Domonkos

@Whaileee
Copy link
Contributor

Whaileee commented Sep 4, 2024

It will be released for 26, so you don't have to worry. Unfortunately, there is no pull request yet, but I can ping you in this thread as soon as I make it available on github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants