Feat: calendar:(universal/local)_time_to_system_time/1,2 #9445
Conversation
CT Test Results 2 files 97 suites 1h 8m 33s ⏱️ Results for commit 9b34810. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
MarkoMin
force-pushed
the
feat/calendar/to_system_time
branch
from
7d1f670 to
b5ead3d
Compare
MarkoMin
force-pushed
the
feat/calendar/to_system_time
branch
from
b5ead3d to
eadf47e
Compare
|
Resolved and squashed |
jhogberg
added
the
testing
|
|
||
| -doc(#{since => <<"OTP 28.0">>}). | ||
| -doc """ | ||
| Converts local time into system time. |
There was a problem hiding this comment.
| Converts local time into system time. | |
| Converts local time into [system time](`e:erts:time_correction.md#os-system-time`). | |
Add a link to system time definition and a new-line to only make the above part of the function summary.
There was a problem hiding this comment.
Or is it POSIX Time that we are converting to... I always get all these time variants mixed up...
There was a problem hiding this comment.
I think that all functions in this module assume POSIX time... You can pass it any timestamp as an input and the conversion doesn't depend on OS time, right? I think that link to OS system time would create confusion
Co-authored-by: John Högberg <john@erlang.org>
Added missing conversions.
Added proper tests. I've tried them locally with
properI really hope it's not too late to get it into OTP 28...
Closes #8160