Skip to content

delete snmpa_mib_data_ttln.erl #9675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

Conversation

ilya-klyuchnikov
Copy link
Contributor

  1. This module is not compilable. It uses record fields that are not defined.

-record(mib_data, {mib_db, % table of #mib_info
node_db, % table of #node_info
tree_db, % table of #tree
tree, % The actual tree
subagents = []}).

#mib_data{mib_db = MibDb,
node_db = NodeDb,
tree_db = TreeDb,
mtree = MTree}.

  1. it's not part of the builds
  2. it breaks tooling - .elp.toml - configuring ELP to resolve all files and macros in OTP libs #9674
  3. delete it

Copy link
Contributor

github-actions bot commented Apr 3, 2025

CT Test Results

  2 files   24 suites   47m 49s ⏱️
497 tests 469 ✅  28 💤 0 ❌
653 runs  517 ✅ 136 💤 0 ❌

Results for commit 8de0737.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Apr 7, 2025
@bmk bmk added the testing currently being tested, tag is used by OTP internal CI label Apr 10, 2025
@bmk
Copy link
Contributor

bmk commented Apr 10, 2025

There is also a comment in lib/snmp/src/agent/module.mk (referring to snmpa_mib_data_ttln)
Please remove it also.

@ilya-klyuchnikov
Copy link
Contributor Author

cleaned up lib/snmp/src/agent/module.mk

@ilya-klyuchnikov
Copy link
Contributor Author

@bmk - is there anything more needed for this PR? thanks

@bmk
Copy link
Contributor

bmk commented Apr 16, 2025

No, I have mostly been waiting for RC3 to be released (which it is now).
Let it run over the weekend and then we can merge.

@ilya-klyuchnikov
Copy link
Contributor Author

@bmk , ping. RC3 is out and the weekend is over. It seems that it can be safely merged then.
Thanks

@bmk bmk merged commit 0ab6900 into erlang:master Apr 22, 2025
23 of 24 checks passed
@bmk bmk removed the testing currently being tested, tag is used by OTP internal CI label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants