Moved ec_git_vsn tests into separate file
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferd
reviewed
Jul 29, 2024
src/ec_git_vsn.erl
Outdated
| @@ -15,7 +15,10 @@ | |||
|
|
|||
| %% API | |||
| -export([new/0, | |||
| vsn/1]). | |||
| vsn/1, | |||
| parse_tags/1, | |||
There was a problem hiding this comment.
if these are internal exports, we may want to have a macro'd out -ifdef(TEST). -export([...]). -endif. that makes sure we don't include and exposes these calls from a parent library. This avoids accidentally exposing functions we don't plan on exposing.
There was a problem hiding this comment.
That's true; I changed it.
ariel-anieli
force-pushed
the
git-vsn-tests
branch
from
7729cc2
to
d24ad72
Compare
ferd
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.