Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic VCS tagging #1

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Automatic VCS tagging #1

merged 7 commits into from
Jul 5, 2024

Conversation

errordeveloper
Copy link
Owner

No description provided.

@errordeveloper errordeveloper force-pushed the semver-tagger branch 2 times, most recently from 84cf365 to ae6b500 Compare June 26, 2024 17:20
oci/artefact.go Outdated Show resolved Hide resolved
@errordeveloper
Copy link
Owner Author

errordeveloper commented Jun 26, 2024

TODOs

  • support multiple tags
  • add tests for tags in attestations (this actually covered by artifact tagging code that relies on attestations)
  • add tests for tagging of artifacts

- extend Git attestations to store tags
- implement conversion of generic statement type to concrete types
- parse tags from attestations and use for artifacts
- ignore errors when a symlink cannot be open
  - it's not uncommon for Git repos to contain symlinks that are
    intentionally broken, e.g. in case one is pointing to a file
    that a user is meant to install
- handle top-level dir properly
  - previously the code was checking parent dir first and foremost,
    skipping the case when the top-level dir is the starting point
@errordeveloper errordeveloper marked this pull request as ready for review July 5, 2024 11:48
@errordeveloper errordeveloper merged commit 0da9d6a into main Jul 5, 2024
1 check passed
@errordeveloper errordeveloper deleted the semver-tagger branch July 5, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant