-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GitHub Actions, fixed PHP 8.4 deprecation #186
Conversation
# Conflicts: # .gitignore # .travis.yml # composer.json
@erusev I've successfully gotten the CI tests to pass across PHP versions 7.1 - 8.4. Should be ready for review. |
@erusev FYI this is ready for review |
Thanks, will try to review it this weekend 🗓️ |
composer.json
Outdated
} | ||
], | ||
"require": { | ||
"erusev/parsedown": "^1.8.0|^1.8.0-beta-4", | ||
"php": ">=5.3.6", | ||
"erusev/parsedown": "1.8.x-dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's 1.8.x-dev
? Is it referring to the 1.8.x-beta
branch? That branch was recently merged into main
and deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to dev-master because that contains the latest commits. Let me know if there's a specific version I should be pointing to.
.gitignore
Outdated
@@ -1,2 +1,4 @@ | |||
vendor/ | |||
.idea/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this belongs here — it's not about the repo but rather about the developer, and perhaps the global .gitignore
is a better place for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in the latest commit
@erusev could you, please, release a new tag with this fix? |
@erusev Can you tag 0.8.2? |
No description provided.