Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitHub Actions, fixed PHP 8.4 deprecation #186

Merged
merged 19 commits into from
Nov 3, 2024

Conversation

davidbyoung
Copy link
Contributor

No description provided.

@davidbyoung
Copy link
Contributor Author

@erusev I've successfully gotten the CI tests to pass across PHP versions 7.1 - 8.4. Should be ready for review.

@davidbyoung
Copy link
Contributor Author

@erusev FYI this is ready for review

@erusev
Copy link
Owner

erusev commented Oct 28, 2024

Thanks, will try to review it this weekend 🗓️

composer.json Outdated
}
],
"require": {
"erusev/parsedown": "^1.8.0|^1.8.0-beta-4",
"php": ">=5.3.6",
"erusev/parsedown": "1.8.x-dev",
Copy link
Owner

@erusev erusev Nov 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's 1.8.x-dev? Is it referring to the 1.8.x-beta branch? That branch was recently merged into main and deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to dev-master because that contains the latest commits. Let me know if there's a specific version I should be pointing to.

.gitignore Outdated
@@ -1,2 +1,4 @@
vendor/
.idea/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this belongs here — it's not about the repo but rather about the developer, and perhaps the global .gitignore is a better place for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in the latest commit

@erusev erusev merged commit acebd17 into erusev:master Nov 3, 2024
9 checks passed
@davidbyoung davidbyoung mentioned this pull request Nov 3, 2024
@davidbyoung davidbyoung deleted the php-8.4 branch November 16, 2024 00:56
@robsontenorio
Copy link

robsontenorio commented Dec 28, 2024

@erusev could you, please, release a new tag with this fix?

@davidbyoung
Copy link
Contributor Author

@erusev Can you tag 0.8.2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants