Skip to content

test side by side #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
esahmed21 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

test side by side #10

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
60412aa
Update PRW.swift
esahmed21 Feb 24, 2021
5c67dcd
Update PRW.swift
esahmed21 Feb 24, 2021
09a7d55
Merge branch 'master' into esahmed21-patch-8
esahmed21 Dec 12, 2023
dd3ce73
Merge branch 'master' into esahmed21-patch-8
esahmed21 Dec 12, 2023
cf8b6f0
Merge branch 'master' into esahmed21-patch-8
esahmed21 Dec 12, 2023
6f3490c
Merge branch 'master' into esahmed21-patch-8
esahmed21 Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions PRW.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,12 @@ import Lists
import Palette
import SnapKit
import UIKit
final class DeploymentCheckRunCell: UITableViewCell, Bindable { final class DeploymentCheckRunCell: UITableViewCell, Bindable { final class DeploymentCheckRunCell: UITableViewCell, Bindable {

final class DeploymentCheckRunCell: UITableViewCell, Bindable {
Copy link
Owner Author

@esahmed21 esahmed21 Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change

final class DeploymentCheckRunCell: UITableViewCell, Bindable {final class DeploymentCheckRunCell: UITableViewCell, Bindable {

private static let iconSize = grid(5)
Copy link
Owner Author

@esahmed21 esahmed21 Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test left comment


private let titleLabel = applying(UILabel(), compose(
Palette.numberOfLines(0),
Palette.textColor(Asset.textPrimary.color),
Palette.font(.preferredFont(forTextStyle: .body))
))

private let trailingTitleLabel = applying(UILabel(), compose(
Palette.numberOfLines(0),
Palette.textColor(Asset.textTertiary.color),
Palette.font(.preferredFont(forTextStyle: .callout))
))

private let leadingIconImageView = applying(UIImageView(), compose(
Palette.image(Asset.workflow24.image),
Expand Down Expand Up @@ -73,6 +63,19 @@ final class DeploymentCheckRunCell: UITableViewCell, Bindable {
rotateAnimation.isRemovedOnCompletion = false
return rotateAnimation
}()
private static let iconSize = grid(5)
Copy link
Owner Author

@esahmed21 esahmed21 Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test right comment

Comment on lines 64 to +66
Copy link
Owner Author

@esahmed21 esahmed21 Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test right comment edited and non edited


private let titleLabel = applying(UILabel(), compose(
Palette.numberOfLines(0),
Palette.textColor(Asset.textPrimary.color),
Palette.font(.preferredFont(forTextStyle: .body))
))

private let trailingTitleLabel = applying(UILabel(), compose(
Palette.numberOfLines(0),
Palette.textColor(Asset.textTertiary.color),
Palette.font(.preferredFont(forTextStyle: .callout))
))

func bind(viewModel: CheckRunViewModel) {
titleLabel.text = viewModel.name
Expand Down