Merge pull request #12 from esbenp/fix-8

Move reporter binding to service provider

src/ExceptionHandler.php

@@ -71,7 +71,9 @@ public function report(Exception $e)
 
             $config = isset($reporter['config']) && is_array($reporter['config']) ? $reporter['config'] : [];
 
-            $reporterInstance = $this->container->make($class, [$config]);
+            // $this->container->make($class)($config) fails php <= 5.4
+            $reporterFactory = $this->container->make($class);
+            $reporterInstance = $reporterFactory($config);
 
             $this->reportResponses[$key] = $reporterInstance->report($e);
         }

src/Provider/LaravelServiceProvider.php

@@ -3,13 +3,16 @@
 namespace Optimus\Heimdal\Provider;
 
 use Illuminate\Support\ServiceProvider as BaseProvider;
+use Optimus\Heimdal\Reporters\BugsnagReporter;
+use Optimus\Heimdal\Reporters\SentryReporter;
 
 class LaravelServiceProvider extends BaseProvider {
 
     public function register()
     {
         $this->loadConfig();
         $this->registerAssets();
+        $this->bindReporters();
     }
 
     private function registerAssets()
@@ -25,4 +28,19 @@ private function loadConfig()
             $this->app['config']->set('optimus.heimdal', require __DIR__.'/../config/optimus.heimdal.php');
         }
     }
+
+    private function bindReporters()
+    {
+        $this->app->bind(BugsnagReporter::class, function ($app) {
+            return function (array $config) {
+                return new BugsnagReporter($config);
+            };
+        });
+
+        $this->app->bind(SentryReporter::class, function ($app) {
+            return function (array $config) {
+                return new SentryReporter($config);
+            };
+        });
+    }
 }

tests/ExceptionHandlerTest.php

@@ -38,6 +38,12 @@ public function setUp()
      */
     private function createHandler()
     {
+        app()->bind(TestReporter::class, function($app){
+            return function (array $config) {
+                return new TestReporter($config);
+            };
+        });
+
         return app()->make(ExceptionHandler::class);
     }