Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format modules according to new NEBULA #3

Merged
merged 12 commits into from
May 17, 2024
Merged

Conversation

Cmurilochem
Copy link
Collaborator

No description provided.

@raar1
Copy link
Contributor

raar1 commented May 17, 2024

@Cmurilochem OK so the problem was that the deployment script was configured to pull from the main branch (content_ref was set to main) which didn't contain some of your new markdown files (e.g. info.md) resulting in somewhat cryptic looking errors during pre-rendering:

[log] [nitro]   ├─ /api/_content/query/JGHrabsM16.1715865825256.json (3ms)
  │ ├── Error: [404] Document not found!
  │ └── Linked from /NEBULA-content-template/modules/module1/info

I changed the content_ref to point to github.ref which always points to the current branch you've checked out (in this case, update_module_format branch) and the workflow finishes successfully.

We can run with this for now, although we will need to make a 'dummy' deploy workflow so that this doesn't actually get pushed to gh-pages (before we've actually agreed to merge with main). I will make some modifications on the NEBULA to allow this to happen. But for now I think it's ok if you merge this or otherwise continue with what you were doing :)

@Cmurilochem
Copy link
Collaborator Author

@Cmurilochem OK so the problem was that the deployment script was configured to pull from the main branch (content_ref was set to main) which didn't contain some of your new markdown files (e.g. info.md) resulting in somewhat cryptic looking errors during pre-rendering:

[log] [nitro]   ├─ /api/_content/query/JGHrabsM16.1715865825256.json (3ms)
  │ ├── Error: [404] Document not found!
  │ └── Linked from /NEBULA-content-template/modules/module1/info

I changed the content_ref to point to github.ref which always points to the current branch you've checked out (in this case, update_module_format branch) and the workflow finishes successfully.

We can run with this for now, although we will need to make a 'dummy' deploy workflow so that this doesn't actually get pushed to gh-pages (before we've actually agreed to merge with main). I will make some modifications on the NEBULA to allow this to happen. But for now I think it's ok if you merge this or otherwise continue with what you were doing :)

Haaaaaaa @raar1. Thank you so much! So, this was the problem then 😀. Thanks for your help!

@Cmurilochem Cmurilochem merged commit bbf9aad into main May 17, 2024
1 check passed
@Cmurilochem Cmurilochem deleted the update_module_format branch May 17, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants