-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update install instructions for people who do not have nvm or npm installed #116
Conversation
README.md
Outdated
Finally, you can install the node package manager itself. Make sure you install it in the content repository directory | ||
```bash | ||
cd /path/to/your/content/repository | ||
npm install -g npm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remind me whether this needed to be in the content directory or in the nebula directory...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm install needs to be run in the NEBULA directory, and we need to run npm install
, without the -g npm.
npm install
is the instruction to install all dependencies read from the package.json in the current directory. At the same time npm install npm
tells npm to install/update only the npm package, which is itself according to the requirements in package.json as a dependency of the current project. The -g flag tells npm to upgrade npm globally to the newest version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking we might want to move the instructions for installing nvm, node and npm to the NEBULA documentation instead of this README. But if you apply these changes, I'm happy to merge it here and then later move it to NEBULA if we think that is a better place.
README.md
Outdated
|
||
Check whether you have npm installed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check whether you have npm installed: | |
Check whether you have node and npm installed: |
Co-authored-by: Jaro Camphuijsen <j.camphuijsen@esciencecenter.nl>
Co-authored-by: Jaro Camphuijsen <j.camphuijsen@esciencecenter.nl>
Co-authored-by: Jaro Camphuijsen <j.camphuijsen@esciencecenter.nl>
Co-authored-by: Jaro Camphuijsen <j.camphuijsen@esciencecenter.nl>
Co-authored-by: Jaro Camphuijsen <j.camphuijsen@esciencecenter.nl>
Co-authored-by: Jaro Camphuijsen <j.camphuijsen@esciencecenter.nl>
I agree it would be best to have the information NEBULA repo. Feel free to go ahead as you suggested to merge here (I accepted all your suggestions) and then transfer it or immediately move the instructions there, whichever you find more convenient. |
These are the instructions I just followed. They were found here and here, but it was a bit of a hassle to delve through the links to find the specific instructions required.