SMP module #145
Open
SMP module #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniBodor
force-pushed
the
smp_module_dbodor
branch
from
c9da142
to
1bf8891
Compare
DaniBodor
force-pushed
the
smp_module_dbodor
branch
from
0342046
to
f22db21
Compare
DaniBodor
commented
Nov 6, 2024
| 1. **Purpose**: what is the reason or expected end-use for the software? | ||
| 2. **Reliability**: what is the effect of software failure and/or non-maintenance? | ||
| 3. **Maintenance**: what is the long-term effort needed to maintain the software? | ||
| 4. **Lifetime**: How long do you expect (wish) the software to remain in use? |
There was a problem hiding this comment.
I added "Lifetime" to this list in #133 , not realizing that the other 3 points were as listed in the practical guide. I still think it's a good consideration and would like to leave it, but this now does deviate a bit from the guide.
What do you think?
|
I am not sure why the check is failing and/or what I can do to solve this. |
|
@DaniBodor is this PR ready for review or were you just stuck with the failing check? |
Co-authored-by: Jaro Camphuijsen <j.camphuijsen@esciencecenter.nl>
it's ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reworked the SMP module here, mainly the slides.