Fix linter warnings #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: add required fields to related functions for exhaustruct lint warning chore: remove nolint:varnamelen comments because rule disabled in config already feat(logfx): improve replacerGenerator function - add key-value attributes in prettyMode - change switch statement to if at error handling feat(logfx): improve error handling in Handler - Add error wrapping to Handle method - Update WithAttrs and WithGroup methods to retain writer and config fields revert "chore: Add Out field to related functions for exhaustruct lint warning" This reverts commit 1ef434f. Revert "chore: add required fields to related functions for exhaustruct lint warning" This reverts commit 1ad0dfc. refactor(logfx): improve replacerGenerator function - Change key-value attributes in prettyMode to empty
eser
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
Fixes #8
Changes proposed
Check List (Check all the applicable boxes)
changes.
Screenshots
Note to reviewers
There are a lot of things to change, for now I'm categorizing them based on warnings and fix them step by step. I simply proceed from what I can figure out. For now, I left exhaustruct warnings that need to be examined in detail. I opened this PR so it can be tracked.