Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build wheels #416

Merged
merged 31 commits into from
Jan 24, 2025
Merged

feat: build wheels #416

merged 31 commits into from
Jan 24, 2025

Conversation

beckermr
Copy link
Collaborator

@beckermr beckermr commented Jan 17, 2025

This PR adds wheel builds.

to do:

  • add code to install each wheel and run the test suite

@ntessore
Copy link
Contributor

FWIW, I've found it very useful to have a manual trigger for the cibuildwheel workflow, with optional input for the git ref to be built, and optional cibw build/skip override. That way, you can always use the latest build workflow to backfill wheels of old releases, e.g., for new Python versions.

.github/workflows/wheel.yml Outdated Show resolved Hide resolved
@beckermr beckermr marked this pull request as ready for review January 23, 2025 13:21
@beckermr
Copy link
Collaborator Author

OK @esheldon shall we merge?

@beckermr
Copy link
Collaborator Author

I can attempt to push the wheels using the workflow dispatch once the PR is merged.

@esheldon
Copy link
Owner

How are you testing that the wheels work, are available through pypi etc?

@beckermr
Copy link
Collaborator Author

beckermr commented Jan 23, 2025

So available on pypi we cannot test. If the uploads fail when it tries, we'll see the failure in CI and so I am not worried about that.

For testing the actual wheels, I am testing a single version of python (3.11 or 3.12 depending on the architecture). I use pytest directly running on the installed wheel.

See the sections of the workflow that look like this:

- name: test wheel for python ${{ env.PYVER }}
  run: |
    pystr='${{ env.PYVER }}'
    pystr=${pystr//./}
    python -m pip install pip
    pip install numpy pytest
    pip install ./wheelhouse/*cp${pystr}*.whl
    pytest --pyargs fitsio

@beckermr beckermr requested a review from esheldon January 24, 2025 12:34
@beckermr
Copy link
Collaborator Author

Shall we merge here?

@beckermr beckermr merged commit 7c54de2 into master Jan 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants