Make input optional for get_detection_mask #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to understand the refactoring before I can comment further on this. |
|
Does the refactoring aspect matter here? All the call in this repo can still pass the argument. |
esheldon
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #218 , @esheldon introduced
get_detection_maskfunction, which sets the config depending on the Exposure data. This interferes with the upcoming refactoring indicated in #220 , since config values must be set before any data is processed. The minimally distruptive solution seems to be making the input argument optional. Based on this,BRIGHTmask plane is also deprecated, so I don't expect any issues because of not providing the input argument.