Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CETS joining logic more reliable #12

Merged
merged 17 commits into from
Aug 4, 2023
Merged

Make CETS joining logic more reliable #12

merged 17 commits into from
Aug 4, 2023

Commits on Aug 3, 2023

  1. Add join_fails_before_send_dump testcase 

    Add step function into cets_join
    @arcusfelis
    arcusfelis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d0cca83 View commit details
    Browse the repository at this point in the history

  2. Set join_ref in state

    @arcusfelis
    arcusfelis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d487027 View commit details
    Browse the repository at this point in the history

  3. Send check_server message after unpause 

    So servers could verify if join_ref matches
    @arcusfelis
    arcusfelis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    58e4dca View commit details
    Browse the repository at this point in the history

  4. Add join_ref into remote_op messages 

    Add join_fails_before_send_dump_and_there_are_pending_remote_ops testcase
    @arcusfelis
    arcusfelis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    04e0cad View commit details
    Browse the repository at this point in the history

  5. Add send_dump_fails_during_join_because_receiver_exits testcase

    @arcusfelis
    arcusfelis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    3958e73 View commit details
    Browse the repository at this point in the history

  6. Add check_fully_connected check in cets_join 

    Add join_fails_in_check_fully_connected testcase
    @arcusfelis
    arcusfelis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    1dc4b7d View commit details
    Browse the repository at this point in the history

  7. Add join_fails_because_join_refs_do_not_match_for_nodes_in_segment te… 

    …stcase

Add join_fails_because_pids_do_not_match_for_nodes_in_segment testcase
    @arcusfelis
    arcusfelis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    14f3654 View commit details
    Browse the repository at this point in the history

  8. Add remote_ops_are_ignored_if_join_ref_does_not_match testcase

    @arcusfelis
    arcusfelis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    b94981b View commit details
    Browse the repository at this point in the history

  9. Fix types

    @arcusfelis
    arcusfelis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    aef32b8 View commit details
    Browse the repository at this point in the history

  10. Add step_handler types in cets_join

    @arcusfelis
    arcusfelis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    3036244 View commit details
    Browse the repository at this point in the history

  11. Add join_fails_if_lock_is_busy testcase

    @arcusfelis
    arcusfelis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    c82ed23 View commit details
    Browse the repository at this point in the history

  12. Add join_fails_because_server_process_not_found testcase

    @arcusfelis
    arcusfelis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    9a33b6d View commit details
    Browse the repository at this point in the history

  13. Replace run_safely with run_tracked 

    Catching errors and converting errors to tuples is a bad idea
Because it makes giant nested errors
    @arcusfelis
    arcusfelis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    66c9344 View commit details
    Browse the repository at this point in the history

  14. Add run_spawn_forwards_errors testcase

    @arcusfelis
    arcusfelis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    17c1607 View commit details
    Browse the repository at this point in the history

  15. Temporary do not use multiline LOG_ statements 

    They break coverage report (underreported lines)
    @arcusfelis
    arcusfelis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    5ac08f9 View commit details
    Browse the repository at this point in the history

  16. Rewrite cets:add_servers/2 

    Add check_do_not_overlap into cets_join
    @arcusfelis
    arcusfelis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d94c5c2 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Rename steps to checkpoints

    @arcusfelis
    arcusfelis committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    2cbb2d4 View commit details
    Browse the repository at this point in the history