Fix logger cover #23
Merged
Fix logger cover #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After discussing the bug with the OTP team, the best solution is to run tests one more time but without the logger (i.e. to cover the second clause in the macro) erlang/otp#7531
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage 91.01% 91.01%
=======================================
Files 8 8
Lines 434 434
=======================================
Hits 395 395
Misses 39 39
☔ View full report in Codecov by Sentry. |
NelsonVides
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses MIM-2010:
Changes:
Log = #{...}, ?LOG_ERROR(Log)workaround.More info about what it does erlang/otp#7531