Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint scope analyzer error #47

Closed
wants to merge 1 commit into from
Closed

Conversation

amareshsm
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

I cleaned up dependencies by removing those not used in the repository. While doing this I assumed assert is not getting used and removed it. Then the scope view broke and got to know assert is getting used by eslint-scope package.

Image

https://github.com/eslint/js/blob/79c6e93ba93b46186ebfac111c94f44ab3b4ee27/packages/eslint-scope/lib/scope-manager.js#L187

What changes did you make? (Give an overview)

Added assert package

Related Issues

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Sep 9, 2024
@amareshsm amareshsm marked this pull request as ready for review September 9, 2024 21:12
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for eslint-code-explorer ready!

Name Link
🔨 Latest commit 0189a38
🔍 Latest deploy log https://app.netlify.com/sites/eslint-code-explorer/deploys/66df64ab185fdc0008063482
😎 Deploy Preview https://deploy-preview-47--eslint-code-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nzakas
Copy link
Member

nzakas commented Sep 10, 2024

I'd rather fix this: eslint/js#625

Copy link
Member Author

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have decided to completely remove references to assert, as discussed here, this PR is no longer necessary.

@amareshsm
Copy link
Member Author

Closing this PR in favour of eslint/js#626

@amareshsm amareshsm closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants