Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: style issues in no-js mode #628

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Tanujkanti4441
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

There are some styles that are different in no-js mode as compared enabled javascript mode.

What changes did you make? (Give an overview)

This PR fixes following style in no-js mode.

JavaScript Enabled JavaScript Disabled

Related Issues

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Sep 17, 2024
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e0e5fb5
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/66ea834a527b340008b205c2
😎 Deploy Preview https://deploy-preview-628--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit e0e5fb5
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/66ea834aa1e04d0008446ab2
😎 Deploy Preview https://deploy-preview-628--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit e0e5fb5
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/66ea834a6f1e6c000806da23
😎 Deploy Preview https://deploy-preview-628--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit e0e5fb5
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/66ea834ad3e16c0008797d5a
😎 Deploy Preview https://deploy-preview-628--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit e0e5fb5
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/66ea834a6254430008f825bb
😎 Deploy Preview https://deploy-preview-628--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit e0e5fb5
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/66ea834af57681000882b704
😎 Deploy Preview https://deploy-preview-628--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit e0e5fb5
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/66ea834a11618b000848f0ee
😎 Deploy Preview https://deploy-preview-628--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit e0e5fb5
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/66ea834a23bb8900082e86a2
😎 Deploy Preview https://deploy-preview-628--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint issue; Prettier is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working
Projects
Status: Implementing
Development

Successfully merging this pull request may close these issues.

2 participants