Merged
Conversation
* Add brightness controls to gui and menu * Update how gpio isr and i2c are initialized to make the ISRs on CPU1 since CPU0 gets full - have to initialize them from within a task * Update hal to use and expose new display brightness controls
…nd/or gnuboy, and seems to be worse when loading)
…elayout menu to make it more compact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Closes #40
Related ESPP PR: esp-cpp/espp#131
Note: adding the brightness controls (which uses the ESP32 LED controller hardware) required reallocating some of the peripheral interrupts (I2C & GPIO) on Core 1 since Core 0 was filled and could not allocate additional interrupts. Here is the interrupt status for both cores now:
box-emu-fps-brightness-compressed.mp4
How has this been tested?
Building and running on ESP-BOX-EMU
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
display-brightness-compressed.mp4
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.