fix(task): call vTaskDelete at end of std::thread in `task::run_o…

…n_core_non_blocking` (#353)

* Ensure the detached task function calls `vTaskDelete(nullptr)` instead of returning. It is not needed in the `Task` itself because we do a `join` on that thread instead of detaching

components/task/include/run_on_core.hpp

@@ -151,7 +151,13 @@ static void run_on_core_non_blocking(const auto &f, int core_id, size_t stack_si
     f();
     return;
   }
-  auto thread = std::thread(f);
+  auto thread = std::thread(
+      [](const auto &f) {
+        f();
+        // delete ourselves (the task that was created by the thread)
+        vTaskDelete(nullptr);
+      },
+      f);
   thread.detach();
 }
 

components/task/src/task.cpp

@@ -268,5 +268,5 @@ void Task::thread_function() {
       }
     }
 #endif // ESP_PLATFORM
-  }
+  }    // while (started_)
 }