Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ads1x15): update to use pure read function #133

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Dec 13, 2023

Description

  • feat(ads1x15): update to use pure read function and protect internal read_two function with mutex to make API more consistent with the other analog expander classes
  • Update affected examples (ads1x15 and controller)
  • Rebuild docs

Motivation and Context

Allows the use of the same read/write functions across the analog expander classes currently offered (Ads1x15, Ads7138, Tla2528).

How has this been tested?

Building the ads1x15 example.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

…read_two function with mutex to make API more consistent with the other analog expander classes
@finger563 finger563 merged commit d261e53 into main Dec 13, 2023
47 checks passed
@finger563 finger563 deleted the feature/ads1x15-read-only branch December 13, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant