Skip to content

fix: subscriber callback not removed #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

finger563
Copy link
Contributor

Description

  • Updated remove_subscriber implementation to use reference when erasing callback from list to ensure that it is properly erased from the shared state
  • Added some warnings if removal occurs when topic or component are not found

Motivation and Context

Fixes a bug where the subscriber callback was not removed when it should have been, leading to the callback being called later.

How has this been tested?

Building and running within the esp-box-emu project.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project

* Updated remove_subscriber implementation to use reference when erasing callback from list to ensure that it is properly erased from the shared state
* Added some warnings if removal occurs when topic or component are not found
@finger563 finger563 added bug Something isn't working event manager labels Dec 28, 2023
@finger563 finger563 merged commit af0852f into main Dec 28, 2023
@finger563 finger563 deleted the fix/event-manager-remove-subscriber branch December 28, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working event manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant