feat(logger): Add support for cursor commands and expose Logger::get_time() as public
#317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅Static analysis result - no issues found! ✅ |
SquaredPotato
pushed a commit
to smartknob-ha/espp
that referenced
this pull request
Jan 27, 2025
…_time()` as public (esp-cpp#317) * feat(logger): Add support for cursor commands and expose logger::get_time() as public * fix sa and use remaining in print instead of elapsed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
get_time()to be public so others can use it.Motivation and Context
Allows for more complex logging behavior to be developed as well as some simple terminal applications.
Support for the cursor commands (which are static functions) can be compiled in either by setting
ESPP_LOGGER_CURSOR_COMMANDS_ENABLED=1as a compile definition, or by using menuconfig. For ESP-based systems which use menuconfig, the cursor commands are enabled by default.How has this been tested?
Building and running the
logger/exampleon a QtPy ESP32s3.Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.