Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(led): allow LEDC ISR to be configured onto specific cores #328

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Sep 18, 2024

Description

  • Allow LEDC interrupt service (ISR) to be installed on specific cores

Motivation and Context

Similar to the I2C, we'd like to be able to specify which core the interrupt is installed on (since there are only a limited number of slots available on each core).

How has this been tested?

  • Building and running the led/example

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Sep 18, 2024
@finger563 finger563 added enhancement New feature or request led labels Sep 18, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit c64cb02 into main Sep 18, 2024
69 checks passed
@finger563 finger563 deleted the feature/ledc-isr-core branch September 18, 2024 18:58
SquaredPotato pushed a commit to smartknob-ha/espp that referenced this pull request Jan 27, 2025
…pp#328)

* feat(led): allow LEDC ISR to be configured onto specific cores

* add missing include / dep

* update style of comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request led
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant