Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(filters): Update filters example, and expose filters to x-plat library #330

Merged
merged 5 commits into from
Sep 20, 2024
Merged

feat(filters): Update filters example, and expose filters to x-plat library #330

merged 5 commits into from
Sep 20, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Sep 20, 2024 •
edited
Loading

Description

  • Move filter code from hpp into cpp
  • Expose lowpass / simple lowpass filters into python
  • Update filters example to more fully test the filters

Motivation and Context

  • Allows the filter code to be used from within host code c++/python
  • Provides more example for filters

How has this been tested?

  • Building and running filters/example on qtpy esp32s3.
  • Building the library

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2024-09-20 at 15 51 00@2x
filters_example_output.txt

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Sep 20, 2024
@finger563 finger563 added enhancement New feature or request filters xplat cross platform support python labels Sep 20, 2024
@finger563 finger563 changed the title Feature/filter lib update feat(filters): Update filters example, and expose filters to x-plat library Sep 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 6703d78 into main Sep 20, 2024
69 checks passed
@finger563 finger563 deleted the feature/filter-lib-update branch September 20, 2024 23:06
SquaredPotato pushed a commit to smartknob-ha/espp that referenced this pull request Jan 27, 2025
@finger563 @SquaredPotato
feat(filters): Update filters example, and expose filters to x-plat l…
03821c4 
…ibrary (esp-cpp#330)

* feat(filters): Expose lowpass filters to lib and update example

* update example to test more permutations of filters

* fix sa

* add missing cpp files to cmake

* readme: update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@finger563 finger563

Labels
enhancement New feature or request filters python xplat cross platform support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@finger563