Skip to content

feat(interrupt): Add API for tracking and getting the min queue size #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

finger563
Copy link
Contributor

Description

  • Update Interupt to track the minimum number of free spaces in the queue and an API for querying it, over the lifetime of the object

Motivation and Context

In complex systems with many tasks and many interrupts, there is a chance that the configured interrupt queue size (default=10) is too small and may fill up, causing some interrupts to be missed.

This may also help to indicate if there is additional filtering required on the interrupt line (either using the espp::Interrupt::FilterType config or by implementing hardware filtering).

This may also occur if the interrupt handler task priority is too low and there are many other tasks in the system starving the interrupt task of CPU time.

How has this been tested?

Building and running the interrupt/example on a QtPy ESP32s3.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2024-11-28 at 05 44 28

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Update `Interupt` to track the minimum number of free spaces in the queue and an API for querying it, over the lifetime of the object
@finger563 finger563 self-assigned this Nov 28, 2024
@finger563 finger563 added enhancement New feature or request interrupt labels Nov 28, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit f2b334c into main Nov 28, 2024
69 checks passed
@finger563 finger563 deleted the feat/interrupt-min-queue-size branch November 28, 2024 12:21
SquaredPotato pushed a commit to smartknob-ha/espp that referenced this pull request Jan 27, 2025
…sp-cpp#344)

* feat(interrupt): Add API for tracking and getting the min queue size
* Update `Interupt` to track the minimum number of free spaces in the queue and an API for querying it, over the lifetime of the object

* update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request interrupt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant