Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esp-box): Update implementation #345

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

finger563
Copy link
Contributor

Description

  • Break up implementation into different source files
  • Update audio interface to allow configuration of audio task

Motivation and Context

  • Previously, we had manually marked some functions as IRAM_ATTR, but this removes control from application developers who may not need those to be IRAM_ATTR. Application code can now use linker files instead to place the functions into IRAM if they choose to.
  • Previously we had hard-coded the audio task at a specific Task::Config. This PR keeps that as the default, but enables application code to override it if they choose to.

How has this been tested?

  • Building and running esp-box/example on a ESP32-S3-BOX-3
  • Building and running within esp-cpp/esp-box-emu which uses this component.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Break up implementation into different source files
* Update audio interface to allow configuration of audio task
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 added enhancement New feature or request esp-box labels Nov 29, 2024
@finger563 finger563 self-assigned this Nov 29, 2024
@finger563 finger563 merged commit 5327353 into main Nov 29, 2024
69 checks passed
@finger563 finger563 deleted the feat/esp-box-api-update branch November 29, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request esp-box
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant