Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ble): Update esp-nimble-cpp to latest upstream for API refactor #347

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Dec 2, 2024

Description

  • Update esp-nimble-cpp submodule to latest main which matches upstream
  • Update ble_gatt_server, gfps_server, components
  • Update affected examples

Motivation and Context

  • Keeps our submodule up to date with latest, ensuring compatibility and maintainability

This is a minor breaking change to the underlying esp-nimble-cpp API, which makes a small change to the name so that NimBLEDevice::injectConfirmPIN -> NimBLEDevice::injectConfirmPasskey.

How has this been tested?

  • Building ble_gatt_server/example, gfps_service/example, and hid_service/example

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2024-12-02 at 09 42 07

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Update esp-nimble-cpp submodule to latest `main` which matches upstream
* Update `ble_gatt_server`, `gfps_server`, components
* Update affected examples
Copy link

github-actions bot commented Dec 2, 2024

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit babba1e into main Dec 2, 2024
69 checks passed
@finger563 finger563 deleted the feat/nimble-cpp-update branch December 2, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant