Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Vale lints #111

Merged
merged 6 commits into from
Aug 2, 2023
Merged

Conversation

SergioGasquez
Copy link
Member

No description provided.

Copy link
Contributor

@f-hollow f-hollow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for using Vale linter and for giving your feedback. I will implement it ASAP.

My overall impression after reviewing this PR is that it is perfectly fine to question Vale warnings, errors, and suggestions. Fortunately or not, human languages are not easy to standardize. It is impossible to create hard and fast rules on word usage. But no doubt Vale offers quite a few useful comments.

README.md Outdated Show resolved Hide resolved
src/introduction.md Outdated Show resolved Hide resolved
src/introduction.md Outdated Show resolved Hide resolved
src/misc/troubleshooting.md Outdated Show resolved Hide resolved
src/misc/troubleshooting.md Show resolved Hide resolved
src/overview/using-the-standard-library.md Outdated Show resolved Hide resolved
src/tooling/simulating/index.md Outdated Show resolved Hide resolved
src/tooling/simulating/wokwi.md Outdated Show resolved Hide resolved
src/tooling/visual-studio-code.md Outdated Show resolved Hide resolved
src/writing-your-own-application/nostd.md Show resolved Hide resolved
@f-hollow
Copy link
Contributor

f-hollow commented Aug 2, 2023

@SergioGasquez

LGTM!

@SergioGasquez SergioGasquez merged commit eecc192 into esp-rs:main Aug 2, 2023
1 check passed
@SergioGasquez SergioGasquez deleted the feat/vale-linting branch August 2, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants