Add documentation for climate_ir_samsung #4533
Conversation
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DjordjeMandic
left a comment
DjordjeMandic
left a comment
There was a problem hiding this comment.
Could benefit from one short paragraph about confirmed working unit model and remote control model which was used for analysing remote protocol.
swoboda1337
left a comment
swoboda1337
left a comment
There was a problem hiding this comment.
Docs need to be converted to md
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
jorofi
force-pushed
the
component_climate_ir_samsung
branch
2 times, most recently
from
403ff1b to
cab4955
Compare
jorofi
force-pushed
the
component_climate_ir_samsung
branch
from
71ec6cb to
a19d867
Compare
|
Hi @swoboda1337, I’ve addressed all requested changes. Could you please take another look and approve the PR when you have time? |
3 participants
Description:
Added notes for the new Climate IR Samsung component
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable): esphome/esphome#8004
Checklist:
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/index.rstwhen creating new documents for new components or cookbook.