Conversation
|
To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file: external_components:
- source: github://pr#13125
components: [apds9930]
refresh: 1h(Added by the PR bot) |
There was a problem hiding this comment.
👥 Code Ownership
Hey there @iyesin,
Thanks for submitting this pull request! Can you add yourself as a codeowner for this integration? This way we can notify you if a bug report for this integration is reported.
In __init__.py of the integration, please add:
CODEOWNERS = ["@iyesin"]And run script/build_codeowners.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #13125 +/- ##
=======================================
Coverage 73.96% 73.96%
=======================================
Files 55 55
Lines 11575 11575
Branches 1577 1577
=======================================
Hits 8562 8562
Misses 2611 2611
Partials 402 402 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Review dismissed: All requirements have been met
Memory Impact AnalysisComponents:
📊 Component Memory Breakdown
🔍 Symbol-Level Changes (click to expand)Changed Symbols
New Symbols (top 15)
Removed Symbols (top 15)
This analysis runs automatically when components change. Memory usage is measured from a representative test configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
e9b6d53 to
131a50a
Compare
131a50a to
942977c
Compare
e3d1117 to
c3b15aa
Compare
c3b15aa to
0edc6a3
Compare
|
I tested this code on the real hardware. The only problem I found is with the proximity sensor: its feedback is kinda chaotic and all 3 (!!!) sensors I posses, showing me different values. |
Add support for APDS-9930 sensor (ambient light + proximity)
Types of changes
Related issue or feature (if applicable):
Pull request in esphome-docs with documentation (if applicable):
Test Environment
Example entry for
config.yaml:Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: