Skip to content

Commit

Permalink
fix(cmake): Prevent overwriting of component properties in output file
Browse files Browse the repository at this point in the history
While 'component_properties_text'
correctly accumulated properties from all processed components, each
iteration of the loop was overwriting the entire file content.

Move the file(WRITE ...) call outside the loop to ensure all accumulated
component properties are written once, preserving information for all
components.
  • Loading branch information
viayie committed Oct 16, 2024
1 parent a97a7b0 commit bdf0821
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tools/cmake/component.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ endfunction()
# keeps a list of all its properties.
#
function(__component_write_properties output_file)
set(component_properties_text "")
idf_build_get_property(component_targets __COMPONENT_TARGETS)
foreach(component_target ${component_targets})
__component_get_property(component_properties ${component_target} __COMPONENT_PROPERTIES)
Expand All @@ -130,8 +131,8 @@ function(__component_write_properties output_file)
set(component_properties_text
"${component_properties_text}\nset(__component_${component_target}_${property} \"${val}\")")
endforeach()
file(WRITE ${output_file} "${component_properties_text}")
endforeach()
file(WRITE ${output_file} "${component_properties_text}")
endfunction()

#
Expand Down

0 comments on commit bdf0821

Please sign in to comment.