-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(https): Get TLS errors from http client (IDFGH-14265) #15059
base: master
Are you sure you want to change the base?
Conversation
👋 Hello KonssnoK, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
575b1f6
to
7373878
Compare
sha=737387885458924c23fddd541d784d721ad4043e |
@@ -1155,6 +1155,18 @@ int esp_http_client_get_errno(esp_http_client_handle_t client) | |||
return esp_transport_get_errno(client->transport); | |||
} | |||
|
|||
esp_err_t esp_http_client_get_tls_error(esp_http_client_handle_t client, int *tls_code, int *tls_flags){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please API name to esp_http_client_get_and_clear_last_tls_error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
ESP_LOGE(TAG, "Invalid client handle or params"); | ||
return ESP_FAIL; | ||
} | ||
return esp_tls_get_and_clear_last_error( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look into the documentation for API esp_tls_get_and_clear_last_error() and see if all cases are covered correctly or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed params to be optionals as in the callee
esp_err_t esp_tls_get_and_clear_last_error(esp_tls_error_handle_t h, int *esp_tls_code, int *esp_tls_flags)
{
if (!h) {
return ESP_ERR_INVALID_STATE;
}
esp_err_t last_err = h->last_error;
if (esp_tls_code) {
*esp_tls_code = h->esp_tls_error_code;
}
if (esp_tls_flags) {
*esp_tls_flags = h->esp_tls_flags;
}
memset(h, 0, sizeof(esp_tls_last_error_t));
return last_err;
}
7373878
to
5642a72
Compare
Description
Expose TLS errors from HTTPS client