Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(https): Get TLS errors from http client (IDFGH-14265) #15059

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KonssnoK
Copy link
Contributor

Description

Expose TLS errors from HTTPS client

Copy link

github-actions bot commented Dec 19, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello KonssnoK, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 5642a72

@KonssnoK KonssnoK force-pushed the feature/http_tls_error branch from 575b1f6 to 7373878 Compare December 19, 2024 08:37
@KonssnoK KonssnoK changed the title [https] Get TLS errors from http client feat(https): Get TLS errors from http client Dec 19, 2024
@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 19, 2024
@github-actions github-actions bot changed the title feat(https): Get TLS errors from http client feat(https): Get TLS errors from http client (IDFGH-14265) Dec 19, 2024
@nileshkale123 nileshkale123 added PR-Sync-Merge Pull request sync as merge commit and removed PR-Sync-Merge Pull request sync as merge commit labels Dec 20, 2024
@nileshkale123
Copy link
Collaborator

sha=737387885458924c23fddd541d784d721ad4043e

@nileshkale123 nileshkale123 added the PR-Sync-Merge Pull request sync as merge commit label Dec 20, 2024
@@ -1155,6 +1155,18 @@ int esp_http_client_get_errno(esp_http_client_handle_t client)
return esp_transport_get_errno(client->transport);
}

esp_err_t esp_http_client_get_tls_error(esp_http_client_handle_t client, int *tls_code, int *tls_flags){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please API name to esp_http_client_get_and_clear_last_tls_error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ESP_LOGE(TAG, "Invalid client handle or params");
return ESP_FAIL;
}
return esp_tls_get_and_clear_last_error(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look into the documentation for API esp_tls_get_and_clear_last_error() and see if all cases are covered correctly or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed params to be optionals as in the callee

esp_err_t esp_tls_get_and_clear_last_error(esp_tls_error_handle_t h, int *esp_tls_code, int *esp_tls_flags)
{
    if (!h) {
        return ESP_ERR_INVALID_STATE;
    }
    esp_err_t last_err = h->last_error;
    if (esp_tls_code) {
        *esp_tls_code = h->esp_tls_error_code;
    }
    if (esp_tls_flags) {
        *esp_tls_flags = h->esp_tls_flags;
    }
    memset(h, 0, sizeof(esp_tls_last_error_t));
    return last_err;
}

@KonssnoK KonssnoK force-pushed the feature/http_tls_error branch from 7373878 to 5642a72 Compare December 23, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Status: Opened Issue is new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants