-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added component: Console for runtime network interface configuration #332
Merged
david-cermak
merged 2 commits into
espressif:master
from
espressif-abhikroy:components/console_cmd_ifconfig
Nov 30, 2023
Merged
Added component: Console for runtime network interface configuration #332
david-cermak
merged 2 commits into
espressif:master
from
espressif-abhikroy:components/console_cmd_ifconfig
Nov 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espressif-abhikroy
force-pushed
the
components/console_cmd_ifconfig
branch
3 times, most recently
from
July 28, 2023 14:40
ede360d
to
d5fec78
Compare
espressif-abhikroy
force-pushed
the
components/console_cmd_ifconfig
branch
6 times, most recently
from
August 21, 2023 10:00
516174f
to
967f6ad
Compare
kostaond
reviewed
Aug 24, 2023
espressif-abhikroy
force-pushed
the
components/console_cmd_ifconfig
branch
5 times, most recently
from
September 12, 2023 10:56
4d96574
to
212d296
Compare
espressif-abhikroy
force-pushed
the
components/console_cmd_ifconfig
branch
2 times, most recently
from
September 19, 2023 10:06
3784a43
to
e71b04f
Compare
igrr
reviewed
Sep 19, 2023
igrr
reviewed
Sep 19, 2023
igrr
reviewed
Sep 19, 2023
igrr
reviewed
Sep 19, 2023
igrr
reviewed
Sep 19, 2023
igrr
reviewed
Sep 19, 2023
igrr
reviewed
Sep 19, 2023
igrr
reviewed
Sep 19, 2023
espressif-abhikroy
force-pushed
the
components/console_cmd_ifconfig
branch
5 times, most recently
from
October 17, 2023 10:16
a6ccc13
to
63f668d
Compare
david-cermak
requested changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left few minor comments
components/console_cmd_ifconfig/examples/ifconfig-basic/main/idf_component.yml
Outdated
Show resolved
Hide resolved
espressif-abhikroy
force-pushed
the
components/console_cmd_ifconfig
branch
2 times, most recently
from
October 18, 2023 08:27
6ee4739
to
851a0e6
Compare
espressif-abhikroy
force-pushed
the
components/console_cmd_ifconfig
branch
7 times, most recently
from
October 25, 2023 10:06
43413f3
to
8c8d627
Compare
espressif-abhikroy
force-pushed
the
components/console_cmd_ifconfig
branch
2 times, most recently
from
October 26, 2023 10:02
cb00fd9
to
57b522f
Compare
espressif-abhikroy
force-pushed
the
components/console_cmd_ifconfig
branch
from
November 16, 2023 09:05
57b522f
to
0c9266f
Compare
david-cermak
approved these changes
Nov 23, 2023
espressif-abhikroy
force-pushed
the
components/console_cmd_ifconfig
branch
from
November 23, 2023 09:10
0c9266f
to
7ad35b5
Compare
espressif-abhikroy
force-pushed
the
components/console_cmd_ifconfig
branch
from
November 24, 2023 09:07
7ad35b5
to
8bab142
Compare
1.0.0 Features - Console for runtime network interface configuration and monitoring (8bab142)
david-cermak
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console for runtime network interface configuration and monitoring.