fix(mdns): Correction on 6d2c475 MDNS_PREDEF_NETIF_ETH fix #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-cermak
force-pushed
the
fix/mdns_eth
branch
from
6dadd18 to
fc59f87
Compare
|
@gabsuren PTAL, another issue to unbreak master. @marekmaskarinec FYI -- had to rename |
espressif-abhikroy
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes after 6d2c475, which used incorrect config option name
CONFIG_MDNS_NETIF_ETH(instead ofMDNS_PREDEF_NETIF_ETH).Causing master pipeline to fail in https://github.com/espressif/esp-protocols/actions/runs/7553595066/job/20566133750